Issue 4305 - Added in_channel,out_channel,state params to listforwards #4349
Conversation
|
Yep, this is great! We generally dislike underscores in JSON parameters, but the JSON already outputs those names so consistency wins. Tests would ofc be nice, so would docs ;) |
|
Added |
|
Since we switched from (deprecated) Travis to GH actions, I will rebase this now... |
rustyrussell
force-pushed
the
issue_4305
branch
from
0303007
to
267b2a0
Compare
|
Source checks (make check-source) failed because:
Trivial to fix up though! |
rustyrussell
force-pushed
the
issue_4305
branch
from
267b2a0
to
c104712
Compare
|
OK, due to lack of response, I rebased, fixed those check-source errors, and removed the accidental checkin of a binary. And added Changelog-Added. |
rustyrussell
force-pushed
the
issue_4305
branch
from
c104712
to
09ac98a
Compare
|
Trivial to fix up though! I read this and thought you were about to fix it up because it was trivial for you and then forgot about this issue. Sorry, guess I got lost in translation a little bit :) I'll try to pay attention to such errors in my next PR. Navigating C and Python codebase is new water for me. |
Changelog-Added: JSON-RPC: `listforwards` can now filter by status, in and out channel.
|
Had to do a trivial rebase again, since db files changed under us. This time for sure! |
|
Ack 3b9f5f5 |
I've added in_channel,out_channel and state params to listforwards.
I also added an index to forwarded_payments.state to speed up lookups that use this column (eg. getinfo).
TODO: